fix: clean up orphaned BVH nodes when remove creates a partial root#409
Merged
Merged
Conversation
|
Can confirm that this patch fixes my crashes: I hope this gets merged soon. |
When multiple removes occur without an intervening refit, orphaned wide nodes accumulate in the nodes vector. If the root is then reduced to a single leaf (partial root), those orphaned nodes remain, causing optimize_incremental to operate on a corrupt tree and eventually crash. Truncate nodes and parents to 1 after creating a partial root, since only node[0] is reachable in that state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sebcrozet
force-pushed
the
fix-bvh-remove-orphaned-nodes
branch
from
bb76d21 to
763d2a6
Compare
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bvh::removecalls occur without an interveningrefit, orphaned wide nodes accumulate in thenodesvector (by design — the comment says "it will get cleaned up at the next refit"). However, if the root is then reduced to a single leaf (partial root), those orphaned nodes remain, causingoptimize_incrementalto operate on a corrupt tree structure.truncate(1)for bothnodesandparentsafter creating a partial root, since onlynode[0]is reachable in that state.🤖 Generated with Claude Code